-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for scope-default transformer configuration #190
Conversation
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
==========================================
+ Coverage 99.34% 99.37% +0.02%
==========================================
Files 20 21 +1
Lines 614 636 +22
Branches 62 61 -1
==========================================
+ Hits 610 632 +22
Misses 4 4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, next step would be to pass default flags from top to the very bottom 💯
Thank you for taking your time to try this idea.
@d12frosted it's already supported, see these test cases: https://github.com/scalalandio/chimney/pull/190/files#diff-8bf852c2438394dc69a2bd644c2a815eR1017 Or do you mean something else? |
🤔 yeah, you are right. For some reason I was confused since I didn't see ability to pass configuration to |
Good point, let me elaborate. Initially I thought that capturing implicit flags on I could fix it by making
It keeps almost the same semantics, but bring less troubles for the users. |
…cro dependend TransformerConfiguration to separate compilation units
@krzemin ah I see. This is something I didn't consider in my PRs. Nicely done! |
This is wonderful! Thank you @krzemin 🎉 |
Thank you for your efforts too @d12frosted! |
This PR addresses #176. It's result of several prototyping rounds made in cooperation with @d12frosted.
More or less it implements the plan sketched here: #176 (comment)
TODO:
provide analogous mechanism for patcherslet's have it as a separate issue (Implicitly scoped patcher configurations #191)