Default values usage require explicit enabling (changed default setting) #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 99.70% // Head: 99.70% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #227 +/- ##
=======================================
Coverage 99.70% 99.70%
=======================================
Files 26 26
Lines 672 672
Branches 61 58 -3
=======================================
Hits 670 670
Misses 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
krzemin
reviewed
Aug 10, 2022
MateuszKubuszok
force-pushed
the
feature/disable-defaults-by-default
branch
2 times, most recently
from
2fc9ebc to
d63254b
Compare
krzemin
reviewed
Dec 16, 2022
MateuszKubuszok
force-pushed
the
feature/disable-defaults-by-default
branch
from
197d3e7 to
3bf6745
Compare
MateuszKubuszok
temporarily deployed
to
benchmark
GitHub Actions
Inactive
krzemin
approved these changes
Dec 16, 2022
MateuszKubuszok
had a problem deploying
to
benchmark
GitHub Actions
Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a lot of issues caused by default values enabled by default (vide #176 (comment), #192, #200), this PR changes the default setting to
.disableDefaultValues. From now.enableDefaultValuesshould be set explicitly.This is a breaking change, but one which aims for more safety.