Cross compilable Scala 2/3 abstractions #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MateuszKubuszok
force-pushed
the
feature/typed-inner-abatractions
branch
from
de3f966 to
b8de712
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## scala-3 #286 +/- ##
============================================
- Coverage 85.64% 58.26% -27.39%
============================================
Files 31 57 +26
Lines 1066 1567 +501
Branches 98 129 +31
============================================
Hits 913 913
- Misses 153 654 +501
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
5 tasks
…current code could be migrated, one rule by one
…d *Platform files
krzemin
force-pushed
the
feature/typed-inner-abatractions
branch
from
2cf3971 to
8bc7356
Compare
krzemin
requested changes
Mar 18, 2023
.../main/scala/io/scalaland/chimney/internal/compiletime/derivation/DerivationDefinitions.scala
Outdated
Show resolved
Hide resolved
.../src/main/scala/io/scalaland/chimney/internal/compiletime/derivation/DerivationGateway.scala
Outdated
Show resolved
Hide resolved
chimney/src/main/scala/io/scalaland/chimney/internal/compiletime/ConfigurationDefinitions.scala
Outdated
Show resolved
Hide resolved
chimney/src/main/scala/io/scalaland/chimney/internal/compiletime/Definitions.scala
Outdated
Show resolved
Hide resolved
chimney/src/main/scala-3/io/scalaland/chimney/compiletime/DefinitionsPlatform.scala
Show resolved
Hide resolved
chimney/src/main/scala/io/scalaland/chimney/internal/compiletime/ResultDefinitions.scala
Outdated
Show resolved
Hide resolved
chimney/src/main/scala/io/scalaland/chimney/internal/compiletime/ResultDefinitions.scala
Outdated
Show resolved
Hide resolved
krzemin
reviewed
Mar 18, 2023
chimney/src/main/scala/io/scalaland/chimney/internal/compiletime/Definitions.scala
Outdated
Show resolved
Hide resolved
MateuszKubuszok
commented
Mar 28, 2023
chimney/src/main/scala-2/io/scalaland/chimney/internal/compiletime/ConfigurationsPlatform.scala
Show resolved
Hide resolved
MateuszKubuszok
commented
Mar 28, 2023
chimney/src/main/scala-2/io/scalaland/chimney/internal/compiletime/ResultsPlatform.scala
Show resolved
Hide resolved
MateuszKubuszok
commented
Mar 28, 2023
...y/src/main/scala-2/io/scalaland/chimney/internal/compiletime/derivation/LegacyPlatform.scala
Outdated
Show resolved
Hide resolved
MateuszKubuszok
commented
Mar 28, 2023
chimney/src/main/scala-2/io/scalaland/chimney/internal/macros/TransformerMacros.scala
Show resolved
Hide resolved
krzemin
reviewed
Mar 28, 2023
chimney/src/main/scala-2/io/scalaland/chimney/internal/compiletime/DefinitionsPlatform.scala
Outdated
Show resolved
Hide resolved
krzemin
reviewed
Mar 28, 2023
chimney/src/main/scala/io/scalaland/chimney/internal/compiletime/Configurations.scala
Show resolved
Hide resolved
krzemin
reviewed
Mar 28, 2023
chimney/src/main/scala/io/scalaland/chimney/internal/compiletime/Configurations.scala
Outdated
Show resolved
Hide resolved
krzemin
reviewed
Mar 28, 2023
chimney/src/main/scala/io/scalaland/chimney/internal/compiletime/Contexts.scala
Outdated
Show resolved
Hide resolved
krzemin
reviewed
Mar 28, 2023
chimney/src/main/scala/io/scalaland/chimney/internal/compiletime/Contexts.scala
Outdated
Show resolved
Hide resolved
krzemin
reviewed
Mar 28, 2023
chimney/src/main/scala/io/scalaland/chimney/internal/compiletime/Exprs.scala
Outdated
Show resolved
Hide resolved
* Refactor Types abstractions: - split Types (language & stdlib types) and ChimneyTypes (library-specific types) - simplify the API structure * Restructure Scala 2 platform types impl * make Scala 2 code compiling * implement Scala 3 types, make it compile * refactor Exprs interface * implementation of new Expr interface for Scala 2 * implementation of new Expr interface for Scala 3 * remove unused code * resolved TODO comments with implicit exprs resolution * uncomment code
…erContext, fix legacy macro workaround implementation (#294) * Share TransformerDefinitionErrors, split TransformerContext and PatcherContext, fix legacy macro workaround implementation * Improve error handling in Results * Move DerivationResult to a separate file outside mix-in * Remove unnecessary src = src * Fix to actually use the implementation in Gateway
…cros, use proper error reporing in flag parsing
krzemin
changed the title
This was referenced Apr 19, 2023
krzemin
added a commit
that referenced
this pull request
Apr 19, 2023
* The first draft of an elternative structure for macros towards which current code could be migrated, one rule by one * Small cleanup * fixup! Small cleanup * Split Transformer, PartialTransformer and Patcher into shared code and *Platform files * Initial Scala 3 implementation for some of compiletime abstractions * Remodel new types abstractions a bit * Move logging from Context to DerivationResult * Add missing abstractions from old macros * Refactor Types/Exprs module (#293) * Refactor Types abstractions: - split Types (language & stdlib types) and ChimneyTypes (library-specific types) - simplify the API structure * Restructure Scala 2 platform types impl * make Scala 2 code compiling * implement Scala 3 types, make it compile * refactor Exprs interface * implementation of new Expr interface for Scala 2 * implementation of new Expr interface for Scala 3 * remove unused code * resolved TODO comments with implicit exprs resolution * uncomment code * Share TransformerDefinitionErrors, split TransformerContext and PatcherContext, fix legacy macro workaround implementation (#294) * Share TransformerDefinitionErrors, split TransformerContext and PatcherContext, fix legacy macro workaround implementation * Improve error handling in Results * Move DerivationResult to a separate file outside mix-in * Remove unnecessary src = src * Fix to actually use the implementation in Gateway * Remove resolved todo in reportError * Align transformerDefinitionPrefix type with what is used in legacy macros, use proper error reporing in flag parsing * Move derivation related traits to transformer subpackage --------- Co-authored-by: Piotr Krzemiński <2477704+krzemin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a draft proposal for an alternative architecture of macros. (Touching #279 #276).
TODO:
???as trees to make it compile all cases but fail tests in runtime to make the migration process less PITA