Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup majority of compilation warnings on scala-3 branch #289

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

krzemin
Copy link
Member

@krzemin krzemin commented Mar 17, 2023

This PR contains #288, ported and adjusted to scala-3 branch

- cleanup majority of the compilation warnings
- cleanup unused warnings from macro-generated code (Scala 2 only)
@krzemin krzemin added this to the scala-3 milestone Mar 17, 2023
@krzemin krzemin requested a review from MateuszKubuszok March 17, 2023 19:35
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d679766) 85.64% compared to head (ff762c4) 85.64%.

Additional details and impacted files
@@           Coverage Diff            @@
##           scala-3     #289   +/-   ##
========================================
  Coverage    85.64%   85.64%           
========================================
  Files           31       31           
  Lines         1066     1066           
  Branches        98       98           
========================================
  Hits           913      913           
  Misses         153      153           
Impacted Files Coverage Δ
...2/io/scalaland/chimney/internal/macros/Model.scala 100.00% <ø> (ø)
...nd/chimney/internal/macros/TransformerMacros.scala 97.65% <ø> (ø)
...chimney/cats/CatsPartialTransformerImplicits.scala 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@krzemin krzemin merged commit 64e1413 into scala-3 Mar 17, 2023
@krzemin krzemin deleted the cleanup/compilation-warning-3 branch March 17, 2023 19:42
krzemin added a commit that referenced this pull request Apr 19, 2023
- cleanup majority of the compilation warnings
- cleanup unused warnings from macro-generated code (Scala 2 only)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant