Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transformation between value classes and case classes #298

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

krzemin
Copy link
Member

@krzemin krzemin commented Apr 20, 2023

Fixes #297

@krzemin krzemin requested a review from MateuszKubuszok April 20, 2023 21:29
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (ba0d8b6) 98.34% compared to head (8815d68) 98.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
+ Coverage   98.34%   98.35%   +0.01%     
==========================================
  Files          39       41       +2     
  Lines        1147     1156       +9     
  Branches      145      144       -1     
==========================================
+ Hits         1128     1137       +9     
  Misses         19       19              
Impacted Files Coverage Δ
...nd/chimney/internal/utils/EitherOrElseCompat.scala 100.00% <ø> (ø)
...scalaland/chimney/internal/utils/EitherUtils.scala 100.00% <ø> (ø)
...nd/chimney/internal/utils/EitherOrElseCompat.scala 100.00% <100.00%> (ø)
...nd/chimney/internal/macros/TransformerMacros.scala 98.28% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MateuszKubuszok MateuszKubuszok merged commit c87f219 into master Apr 20, 2023
@MateuszKubuszok MateuszKubuszok deleted the fix/issue-297 branch April 20, 2023 21:41
krzemin added a commit that referenced this pull request May 3, 2023
krzemin added a commit that referenced this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transforming to value class from non-value class no longer works (and vice-versa)
2 participants