Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging diagnostics in macros #317

Merged
merged 5 commits into from
May 18, 2023
Merged

Logging diagnostics in macros #317

merged 5 commits into from
May 18, 2023

Conversation

MateuszKubuszok
Copy link
Member

@MateuszKubuszok MateuszKubuszok commented May 4, 2023

  • write code logging messages from DerivationResult, derivation time and final expression
  • add flag which enables logging diagnostic messages during derivation
  • add logs for current derivation rules

@MateuszKubuszok MateuszKubuszok added this to the scala-3 milestone May 4, 2023
@MateuszKubuszok MateuszKubuszok requested a review from krzemin May 4, 2023 21:57
@MateuszKubuszok MateuszKubuszok force-pushed the feature/log-diagnostics branch from 632f938 to d88ab63 Compare May 4, 2023 22:01
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage: 55.55% and project coverage change: -1.02 ⚠️

Comparison is base (2a009db) 86.98% compared to head (9c6dc26) 85.97%.

Additional details and impacted files
@@             Coverage Diff             @@
##           scala-3     #317      +/-   ##
===========================================
- Coverage    86.98%   85.97%   -1.02%     
===========================================
  Files           55       55              
  Lines         1283     1326      +43     
  Branches       123      128       +5     
===========================================
+ Hits          1116     1140      +24     
- Misses         167      186      +19     
Impacted Files Coverage Δ
...d/chimney/internal/compiletime/ExprsPlatform.scala 50.00% <ø> (ø)
...chimney/internal/compiletime/ResultsPlatform.scala 50.00% <0.00%> (-50.00%) ⬇️
...main/scala/io/scalaland/chimney/dsl/FlagsDsl.scala 68.75% <0.00%> (-9.83%) ⬇️
.../chimney/internal/TransformerDerivationError.scala 100.00% <ø> (ø)
.../chimney/internal/compiletime/Configurations.scala 31.25% <0.00%> (-18.75%) ⬇️
...scalaland/chimney/internal/compiletime/Exprs.scala 100.00% <ø> (ø)
...o/scalaland/chimney/internal/compiletime/Log.scala 28.57% <0.00%> (+28.57%) ⬆️
...scalaland/chimney/internal/compiletime/Types.scala 42.85% <0.00%> (-7.15%) ⬇️
...ney/internal/macros/TransformerConfigSupport.scala 96.15% <33.33%> (-1.87%) ⬇️
...compiletime/derivation/transformer/ResultOps.scala 37.50% <37.50%> (ø)
... and 8 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MateuszKubuszok MateuszKubuszok changed the title Draft: Logging diagnostics in macros Logging diagnostics in macros May 5, 2023
MateuszKubuszok and others added 2 commits May 8, 2023 12:35
@krzemin krzemin merged commit cb12e43 into scala-3 May 18, 2023
@krzemin krzemin deleted the feature/log-diagnostics branch May 18, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants