Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing failFast flags to implicit partial transformers #319

Merged
merged 1 commit into from
May 16, 2023

Conversation

krzemin
Copy link
Member

@krzemin krzemin commented May 13, 2023

Added test that proved incorrect calling of implicitly found partial transformers.
They were accidentally always passed failFast flag set to false, regardless of the flag value passed by the caller.

This PR fixes the issue and makes sure we always propagate correct failFast flag value.

@krzemin krzemin added the bug Erroneous behavior in existing features label May 13, 2023
@krzemin krzemin requested a review from MateuszKubuszok May 13, 2023 17:44
@krzemin krzemin added the benchmark Added to PRs which should be benchmarked label May 13, 2023
@krzemin krzemin force-pushed the fix/pt-failfast-flag-implicits branch from 9540573 to 2626826 Compare May 13, 2023 17:47
@codecov
Copy link

codecov bot commented May 13, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4f85ada) 98.35% compared to head (9540573) 98.36%.

❗ Current head 9540573 differs from pull request most recent head 2626826. Consider uploading reports for the commit 2626826 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #319   +/-   ##
=======================================
  Coverage   98.35%   98.36%           
=======================================
  Files          41       41           
  Lines        1156     1161    +5     
  Branches      144      144           
=======================================
+ Hits         1137     1142    +5     
  Misses         19       19           
Impacted Files Coverage Δ
...a/io/scalaland/chimney/internal/macros/Model.scala 100.00% <100.00%> (ø)
...nd/chimney/internal/macros/TransformerMacros.scala 98.28% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@krzemin krzemin temporarily deployed to benchmark May 13, 2023 17:53 — with GitHub Actions Inactive
@MateuszKubuszok MateuszKubuszok merged commit d13911d into master May 16, 2023
@krzemin krzemin deleted the fix/pt-failfast-flag-implicits branch May 18, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Added to PRs which should be benchmarked bug Erroneous behavior in existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants