Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored SealedToSealed rule, re-enabled coproduct ambiguity check n Scala 3, fixed errors with too conservative checks #353

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

MateuszKubuszok
Copy link
Member

@MateuszKubuszok MateuszKubuszok commented Aug 29, 2023

…on Scala 3, fixed errors with too conservative checks
@MateuszKubuszok MateuszKubuszok force-pushed the sealed-trait-ambiguous-instances-fix branch from 6a1d5d3 to ae21893 Compare August 29, 2023 16:33
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 65.04% and project coverage change: +0.07% 🎉

Comparison is base (3ed1415) 79.04% compared to head (9957cb1) 79.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
+ Coverage   79.04%   79.11%   +0.07%     
==========================================
  Files         105      105              
  Lines        3960     3974      +14     
  Branches      178      124      -54     
==========================================
+ Hits         3130     3144      +14     
  Misses        830      830              
Files Changed Coverage Δ
...rmSealedHierarchyToSealedHierarchyRuleModule.scala 67.25% <65.04%> (+7.07%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MateuszKubuszok MateuszKubuszok marked this pull request as draft August 29, 2023 23:32
@MateuszKubuszok
Copy link
Member Author

MateuszKubuszok commented Aug 29, 2023

Blocked by a bug in scala.compiletime.testing.typeCheckErrors, reproduced in https://gist.github.com/MateuszKubuszok/2723c2842b8bf969618f4bd751ba3041.

Tracked at scala/scala3#18484

@MateuszKubuszok MateuszKubuszok added this to the 0.8.0 milestone Aug 29, 2023
@MateuszKubuszok MateuszKubuszok marked this pull request as ready for review September 11, 2023 12:42
@MateuszKubuszok MateuszKubuszok merged commit ac3d2a0 into master Sep 11, 2023
20 of 21 checks passed
@MateuszKubuszok MateuszKubuszok deleted the sealed-trait-ambiguous-instances-fix branch September 11, 2023 12:49
@MateuszKubuszok
Copy link
Member Author

I need this refactors and fixes in other branches, so I cannot wait indefinite time for being able to have this one test being handled properly on Scala 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant