-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align Patcher DSL implementation with Transformers #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
789275e
to
0e67e20
Compare
…just DSL and macros to make it compile without using ImplicitScopeFlags yet
0e67e20
to
4f668f8
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #355 +/- ##
==========================================
+ Coverage 79.02% 79.31% +0.28%
==========================================
Files 105 107 +2
Lines 4020 4060 +40
Branches 191 139 -52
==========================================
+ Hits 3177 3220 +43
+ Misses 843 840 -3
☔ View full report in Codecov by Sentry. |
0a23ff0
to
7ed0ab6
Compare
7ed0ab6
to
225c7b8
Compare
503bed6
to
906acd7
Compare
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any attempt to align
Patcher
s withTransformer
s would inevitably break backward in classes definitions:PatcherCfg
is in fact counterpart toTransformerFlags
without disabling).patch
Since branch 0.8.0 is not yet stabilized we are at luxury of breaking this - users who only update "stable" versions (with the early semver understanding of the word) would face only one such breaking change as opposed to several in the coming months if we would plan ahead these breaking changes and release them only once before some final API cleanup.
TODO:
PatcherCfg
fromPatcherFlags
Cfg <: PatcherCfg
addFlags <: PatcherFlags
FlagsDsl
toTransformerFlagsDsl
, extractPatcherFlagsDsl
PatcherConfiguration
PatcherConfiguration[ImplicitScopeFlags <: PatcherFlags]
PatcherCfg
andPatcherFlags
into configImplicitScopeFlags <: PatcherFlags
Patcher.AutoDerived
to align withTransformer
sPatcher.derive
andPatcher.define