Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow declarations inherited from parents #374

Merged
merged 5 commits into from
Sep 14, 2023

Conversation

MateuszKubuszok
Copy link
Member

@MateuszKubuszok MateuszKubuszok commented Sep 14, 2023

When I was copy-pasting my solution from pipez I accidentally have one Scala version use only local definitions and the other one using all available definitions (inherited or not).

Since I need to fix this before releasing 0.8.0, to keep the old behavior I might as well fix it by allowing inherited declarations, but requiring a flag to use them. It would implement #144.

TODO:

  • new flag
  • keeping tab whether getter is local or inherited
  • filtering out inherited definitions is flag is disabled
  • tests of a new functionality
  • documentation

@MateuszKubuszok MateuszKubuszok added this to the 0.8.0 milestone Sep 14, 2023
@MateuszKubuszok MateuszKubuszok linked an issue Sep 14, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 73.68% and project coverage change: -0.05% ⚠️

Comparison is base (7b196bc) 80.23% compared to head (8e81a57) 80.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
- Coverage   80.23%   80.18%   -0.05%     
==========================================
  Files         109      109              
  Lines        4128     4133       +5     
  Branches      186      172      -14     
==========================================
+ Hits         3312     3314       +2     
- Misses        816      819       +3     
Files Changed Coverage Δ
.../internal/compiletime/datatypes/ProductTypes.scala 84.00% <ø> (ø)
...io/scalaland/chimney/dsl/TransformerFlagsDsl.scala 65.38% <50.00%> (-2.01%) ⬇️
...er/rules/TransformProductToProductRuleModule.scala 61.48% <58.33%> (-0.16%) ⬇️
...letime/derivation/transformer/Configurations.scala 77.50% <77.77%> (-0.07%) ⬇️
...l/compiletime/datatypes/ProductTypesPlatform.scala 87.36% <100.00%> (+0.35%) ⬆️
...ey/internal/compiletime/ChimneyTypesPlatform.scala 85.21% <100.00%> (+0.88%) ⬆️
...ey/internal/compiletime/ChimneyTypesPlatform.scala 70.96% <100.00%> (+0.31%) ⬆️
...nd/chimney/internal/compiletime/ChimneyTypes.scala 93.33% <100.00%> (-6.67%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MateuszKubuszok MateuszKubuszok force-pushed the feature/inherited-declarations branch from 6ce658a to 9ca823c Compare September 14, 2023 19:19
@MateuszKubuszok MateuszKubuszok merged commit d9558e7 into master Sep 14, 2023
@MateuszKubuszok MateuszKubuszok deleted the feature/inherited-declarations branch September 14, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow resolving declarations from parent scope
1 participant