fix: transform into classes with var fields

[hughsimpson]

After creating #400 it struck me that the fix was probably actually pretty simple

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1eca979) 85.76% compared to head (7e3d0aa) 85.71%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
- Coverage   85.76%   85.71%   -0.05%     
==========================================
  Files         118      117       -1     
  Lines        4580     4572       -8     
  Branches      196      201       +5     
==========================================
- Hits         3928     3919       -9     
- Misses        652      653       +1     

Files	Coverage Δ
...l/compiletime/datatypes/ProductTypesPlatform.scala	90.71% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MateuszKubuszok]

Hey, great thanks for the reproduction and fix! I enabled the tests and all of them pass, so I would happyly merge it somewhere later this week. Congratulations on your first contribution!

[hughsimpson]

@MateuszKubuszok pushed up some neater tests if you can retrigger the CI 🙏

[MateuszKubuszok]

@MateuszKubuszok pushed up some neater tests if you can retrigger the CI 🙏

Done!

In general LGTM, the only reason I am not merging this PR (and others) is that GH Actions are eager to break on our benchmarking environment and I would like to have a benchmark for 0.8.0 succeed to finish and get published before I merge new commits. But if that would take too long to fix I would skip it.

[hughsimpson]

Oh yeah just looked. No idea what's going on there tbh, looks on the surface like something running out of memory for only 10kb but that obviously can't really be it unless there's a lot of those 10kb things

[MateuszKubuszok]

Oh yeah just looked. No idea what's going on there tbh, looks on the surface like something running out of memory for only 10kb but that obviously can't really be it unless there's a lot of those 10kb things

That's out own runner that we have to maintain ourselves. (For comparable benchmarks we have to have the same environment). It has some issues that we need to resolve.

[MateuszKubuszok]

Merged, I am not sure when I'll release it, as there are a few more fixes I want to add to master, but it surely will be a part of 0.8.1. Thank you again for your contribution!