Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add withConstructorEither #509

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Add withConstructorEither #509

merged 2 commits into from
Apr 18, 2024

Conversation

MateuszKubuszok
Copy link
Member

I'll add more tests later

@MateuszKubuszok MateuszKubuszok added this to the 1.0.0-RC milestone Apr 18, 2024
@MateuszKubuszok MateuszKubuszok force-pushed the with-constructor-either branch from b8f019e to 8dedcc4 Compare April 18, 2024 12:14
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 16.90141% with 59 lines in your changes are missing coverage. Please review.

Project coverage is 88.98%. Comparing base (38166d6) to head (dee5821).

Files Patch % Lines
...imney/internal/runtime/FuncionEitherToResult.scala 8.19% 56 Missing ⚠️
...etime/dsl/PartialTransformerDefinitionMacros.scala 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #509      +/-   ##
==========================================
- Coverage   90.07%   88.98%   -1.10%     
==========================================
  Files         128      129       +1     
  Lines        5100     5230     +130     
  Branches      443      450       +7     
==========================================
+ Hits         4594     4654      +60     
- Misses        506      576      +70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MateuszKubuszok MateuszKubuszok merged commit c1fa2e0 into master Apr 18, 2024
21 of 23 checks passed
@MateuszKubuszok MateuszKubuszok deleted the with-constructor-either branch April 18, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant