Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor path utility #613

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Refactor path utility #613

merged 2 commits into from
Oct 2, 2024

Conversation

MateuszKubuszok
Copy link
Member

  • allow replacing Path.Root.matching[Foo].select(bar) with Path(_.matching[Foo].select[Bar]) which is closer to how users would define them in DSL
  • merge deriveRecursiveTransformationExpr with deriveRecursiveTransformationExprUpdatingRules by using defaults
  • start keeping book for all the intermediate src we defined so far (they might be just src.field1.field1, but they might also be map( inner => ... ) // <-- inner which would allow us to access .everyItem and friend in field renaming

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.62%. Comparing base (f2cb2a6) to head (d4a1871).
Report is 84 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #613      +/-   ##
==========================================
- Coverage   86.79%   86.62%   -0.17%     
==========================================
  Files         155      155              
  Lines        6012     6042      +30     
  Branches      544      540       -4     
==========================================
+ Hits         5218     5234      +16     
- Misses        794      808      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MateuszKubuszok MateuszKubuszok merged commit 08794da into master Oct 2, 2024
23 of 24 checks passed
@MateuszKubuszok MateuszKubuszok deleted the refactor-path-utility branch October 2, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant