-
-
Notifications
You must be signed in to change notification settings - Fork 108
Rewrite API so that Scala 3 would not rely on AutoDerived pattern (Scala 3.7 givens resolution change) #713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f4c3cc0
to
7950c17
Compare
7950c17
to
6e41588
Compare
…mpiler, and in general try to fix the build
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.0.0-development #713 +/- ##
=====================================================
- Coverage 87.10% 86.98% -0.12%
=====================================================
Files 154 157 +3
Lines 7016 6748 -268
Branches 727 651 -76
=====================================================
- Hits 6111 5870 -241
+ Misses 905 878 -27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ava-collection-commons
implicit def liftTotal[From, To](implicit total: Transformer[From, To]): AutoDerived[From, To] = | ||
(src: From, failFast: Boolean) => partial.Result.fromCatching(total.transform(src)) | ||
} | ||
type AutoDerived[From, To] = Transformer[From, To] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be PartialTransformer[From, To]
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, yes, it should
This PR solves the issue caused by 3.7 givens resolution change:
it no longer relies on this pattern
for recursive (semi)automatic derivation
it uses new Expr.summonIgnoring
AutoDerived
on Scala 3summonIgnoring
on Scala 3Type.prettyPrint
on Scala 3 for internal classes (now they have_
prefix)munit
and Scala.js breaks for Scala 3.7 scala/scala3#22794 - unblockedXfatal-errors
on Scala 3issues/22812 - unblocked
master
to explain issues with 3.7 and provide a workaround (into.transform
instead oftransformInto
, or using macros seems to work!)