This repository has been archived by the owner on Nov 7, 2022. It is now read-only.
Clarify the usage of metals.javaHome #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the main metals repo we've gotten it reported a couple times that the message about setting java home incorrectly sounds like you should set the `java.home` setting, which isn't used by the Metals extensions, but rather the `metals.javaHome` is. This just clarifies that and is a follow-up to the same thing done in the VS Code extension. scalameta/metals-vscode#644
jsatk
approved these changes
Aug 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the main metals repo we've gotten it reported a couple times that the
message about setting java home incorrectly sounds like you should set
the
java.homesetting, which isn't used by the Metals extensions, butrather the
metals.javaHomeis. This just clarifies that and is afollow-up to the same thing done in the VS Code extension. scalameta/metals-vscode#644