Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS preserve extra modifiers #834

Merged
merged 12 commits into from
May 21, 2024
Merged

JS preserve extra modifiers #834

merged 12 commits into from
May 21, 2024

Conversation

Quafadas
Copy link
Contributor

This seems to pass tests locally.

@Quafadas Quafadas marked this pull request as ready for review January 16, 2024 12:16
@Quafadas Quafadas changed the title WIP : JS preserve extra modifiers JS preserve extra modifiers Jan 18, 2024
@Quafadas
Copy link
Contributor Author

Quafadas commented Feb 1, 2024

@tgodzik - Sorry to bother. There's honestly no rush, just want to give a little nudge if you had a moment...

tgodzik
tgodzik requested changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not looking into it before! I totally lost track of this PR.

mdoc/src/main/scala/mdoc/internal/markdown/Processor.scala Show resolved Hide resolved
mdoc-js/src/main/scala/mdoc/modifiers/JsMods.scala Outdated Show resolved Hide resolved
mdoc-js/src/main/scala/mdoc/modifiers/JsModifier.scala Show resolved Hide resolved
@Quafadas
Copy link
Contributor Author

Quafadas commented Feb 9, 2024

No worries, I think I missed the notitfication :-/ ... I've tried to work through the comments you've raised above.

Thankyou very much for review 🙏 .

@Quafadas
Copy link
Contributor Author

Quafadas commented Feb 9, 2024

Huh, I have no idea, why that change should fail the CI. I think maybe it just needs rerunning ... odd.

@tgodzik
Copy link
Contributor

tgodzik commented Feb 25, 2024

The failure looks unrelated, somehow coursier is not working well on windows. We might need to rework the test or ignore it on Windows.

@Quafadas
Copy link
Contributor Author

Thanks again for looking -

@tgodzik
Copy link
Contributor

tgodzik commented Feb 25, 2024

Thanks again for looking -

Sorry it took so long 😓

@Quafadas
Copy link
Contributor Author

Quafadas commented Mar 5, 2024

I rebased this onto main... hopefully, CI goes green...

Quafadas
Quafadas commented Mar 5, 2024
View reviewed changes
Copy link
Contributor Author

@Quafadas Quafadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I seem to have to leave a review. Trying to make github as happy as possible - no issues...

@Quafadas Quafadas requested a review from tgodzik March 5, 2024 16:31
@Quafadas
Copy link
Contributor Author

Quafadas commented Mar 5, 2024

@tgodzik Got CI green again :-)...

@tgodzik
Copy link
Contributor

tgodzik commented May 16, 2024

Och, I somehow lost track of the PR 😨 @Quafadas do you want me to merge?

@Quafadas
Copy link
Contributor Author

No worries - I think so yes please if it's okay.

tgodzik
tgodzik requested changes May 17, 2024
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor things, sorry!

mdoc-js/src/main/scala/mdoc/modifiers/JsMods.scala Outdated Show resolved Hide resolved
tests/jsdocs/package-lock.json Outdated Show resolved Hide resolved
@tgodzik tgodzik merged commit d0b1b3d into scalameta:main May 21, 2024
14 checks passed
@Quafadas
Copy link
Contributor Author

@tgodzik Thankyou! I'm just getting around to checking now - but I think it looks like you've done everything for me.

🙏

Thankyou again.

@Quafadas Quafadas deleted the jasModifierPreserve branch May 21, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Quafadas @tgodzik