CliParser: don't suggest hidden options

metaconfig-core/shared/src/main/scala/metaconfig/cli/HelpCommand.scala

@@ -83,8 +83,8 @@ class HelpCommand(
   }
 
   def notRecognized(subcommand: String, app: CliApp): Int = {
-    val closestSubcommand =
-      Levenshtein.closestCandidate(subcommand, app.commands.map(_.name))
+    val commands = app.commands.filter(!_.isHidden).map(_.name)
+    val closestSubcommand = Levenshtein.closestCandidate(subcommand, commands)
     val didYouMean = closestSubcommand match {
       case None => ""
       case Some(candidate) =>

metaconfig-core/shared/src/main/scala/metaconfig/generic/Settings.scala

@@ -52,6 +52,9 @@ final class Settings[T](
       } yield deprecation).headOption
   }
   def names: List[String] = settings.map(_.name)
+  def nonHiddenNames: List[String] = settings.flatMap { x =>
+    if (x.isHidden) None else Some(x.name)
+  }
   def allNames: List[String] =
     for {
       setting <- settings

metaconfig-core/shared/src/main/scala/metaconfig/internal/CliParser.scala

@@ -97,7 +97,7 @@ class CliParser[T](
             settings.settings.find(_.isCatchInvalidFlags) match {
               case None =>
                 val closestCandidate =
-                  Levenshtein.closestCandidate(camel, settings.names)
+                  Levenshtein.closestCandidate(camel, settings.nonHiddenNames)
                 val didYouMean = closestCandidate match {
                   case None =>
                     ""

metaconfig-core/shared/src/main/scala/metaconfig/internal/NoTyposDecoder.scala

@@ -24,7 +24,7 @@ object NoTyposDecoder {
             key -> obj.pos
         }
         ConfError
-          .invalidFieldsOpt(typos, ev.settings.map(_.name))
+          .invalidFieldsOpt(typos, ev.nonHiddenNames)
           .fold(otherwise)(_.notOk)
     }(conf)
 

metaconfig-tests/jvm/src/test/scala/metaconfig/cli/CliParserSuite.scala

@@ -283,4 +283,12 @@ class CliParserSuite extends BaseCliParserSuite {
        |""".stripMargin
   )
 
+  checkError(
+    "skip hidden",
+    "--hidden1" :: "10" :: Nil,
+    """|found argument '--hidden1' which wasn't expected, or isn't valid in this context.
+       |	Did you mean '--in'?
+       |""".stripMargin
+  )
+
 }