Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure windows tests are run #157

Merged
merged 2 commits into from
Jan 27, 2022
Merged

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Jan 27, 2022

No description provided.

@tgodzik
Copy link
Contributor Author

tgodzik commented Jan 27, 2022

Good, news Windows test managed to run, but we need to bump to Scala native 0.4.3 first.

@tgodzik tgodzik marked this pull request as ready for review January 27, 2022 19:29
@tgodzik tgodzik requested review from keynmol and olafurpg January 27, 2022 19:30
with:
distribution: 'temurin'
java-version: ${{ matrix.java }}
# We need to set proper Pagefile limits in advance.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take from Scala Native CI

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had no idea about this, I'm about to setup some Windows SN workflows, so it's cool to know :)

@tgodzik tgodzik merged commit 3238d74 into scalameta:main Jan 27, 2022
@tgodzik tgodzik deleted the enable-windows branch January 27, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants