Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for Scala Native 0.5.1 #188

Merged
merged 5 commits into from
Jun 18, 2024
Merged

Updates for Scala Native 0.5.1 #188

merged 5 commits into from
Jun 18, 2024

Conversation

ekrich
Copy link
Contributor

@ekrich ekrich commented Apr 16, 2024 •
edited
Loading

@ekrich
Copy link
Contributor Author

ekrich commented Apr 16, 2024

Do we want to update Scala.js to the latest?

@ekrich ekrich mentioned this pull request Apr 16, 2024
Closed
@tgodzik
Copy link
Contributor

tgodzik commented Apr 17, 2024

Do we want to update Scala.js to the latest?

I think that's fine, though probably in a separate PR?

@ekrich
Copy link
Contributor Author

ekrich commented Apr 17, 2024 •
edited
Loading

Oh, I was trying to update everything like sbt-ci-release and other things. I can back off and just touch what needs to be updated or all at once which I think might be better. sbt-native-packager is a weird one because of release problems so not sure on that one.

@tgodzik
Copy link
Contributor

tgodzik commented Apr 17, 2024

Oh, I was trying to update everything like sbt-ci-release and other things. I can back off and just touch what needs to be updated or all at once which I think might be better. sbt-native-packager is a weird one because of release problems so not sure on that one.

it would probably be better one by one, but I wonder why it didn't happen via steward

@ekrich
Copy link
Contributor Author

ekrich commented Apr 17, 2024

Ok, I will just back off to do only the required upgrades.

@tgodzik
Copy link
Contributor

tgodzik commented Apr 17, 2024

Ok, added metaconfig to the repo, that should help in this case. We can wait for the updates to show up, I just run the workflow

@ekrich
Copy link
Contributor Author

ekrich commented Apr 17, 2024

That is great thanks - those can all go through as I wait.

@ekrich
Copy link
Contributor Author

ekrich commented Apr 17, 2024 •
edited
Loading

@tgodzik I will go ahead and rebase when all the updates get merged. Note that sbt-ci-release changed orgs so not sure you will get an update for that one.

@ekrich ekrich changed the title Updates to include Scala Native 0.5.0 Updates for Scala Native 0.5.1 Apr 18, 2024
@ekrich ekrich marked this pull request as ready for review June 17, 2024 18:05
tgodzik
tgodzik requested changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! It's finally passing 🎉

We can just update paiges to latest version and merge.

build.sbt Outdated
@@ -122,8 +122,8 @@ lazy val core = crossProject(JVMPlatform, JSPlatform, NativePlatform)
mimaSettings,
moduleName := "metaconfig-core",
libraryDependencies ++= List(
"org.typelevel" %%% "paiges-core" % "0.4.3",
"org.scala-lang.modules" %%% "scala-collection-compat" % "2.11.0"
"org.typelevel" %%% "paiges-core" % "0.4.3-35-4d6217a-SNAPSHOT",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we can switch to 0.4.4 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated waiting for CI to pass.

tgodzik
tgodzik approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@tgodzik tgodzik merged commit 7c78b86 into scalameta:main Jun 18, 2024
4 checks passed
@tgodzik
Copy link
Contributor

tgodzik commented Jun 18, 2024

Should we do a new release?

@ekrich ekrich deleted the topic/native050 branch June 18, 2024 16:08
@ekrich
Copy link
Contributor Author

ekrich commented Jun 18, 2024

I wanted to update this in case someone ever gets back to trying to port the Scala Native scalafmt. We have multi-threading now so there could be less changes. The diff(ing) part was asked to be a separate project which seemed to be the biggest part of the angst of the large change.

@tgodzik
Copy link
Contributor

tgodzik commented Jun 18, 2024

Och yeah, I did release it separate because of that. I need to return to the PR :|

@ekrich
Copy link
Contributor Author

ekrich commented Jun 18, 2024 •
edited
Loading

Och yeah, I did release it separate because of that.

Do you have a link? We might be able to use it in Scala Native for our tools which we are trying to port to Scala Native as part of a potential "native" tool chain.

@tgodzik
Copy link
Contributor

tgodzik commented Jun 18, 2024

We release is alognside munit https://mvnrepository.com/artifact/org.scalameta/munit-diff

@ekrich ekrich mentioned this pull request Jun 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekrich @tgodzik