Automatically support --no prefix for boolean flags.
#89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if you had boolean flag like `sources: Boolean` with default value true then there was no way for cli users to set the value to false because `--sources` can only set the boolean to true. Now, users can pass the flag `--no-sources` to make the boolean value false. This diff ended up being trickier to implement than I expected because we need to make sure that it's still OK to name fields with a `--no-` prefix, such as `noSources: Boolean`. This feature is implemented in a fully backwards compatible way by always trying first to use the default parsing logic and only falling back to guessing the addition or removal of the `--no-` prefix. This means that a boolean flag named `noSources: Boolean` can also be overriden with the `--sources` flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if you had boolean flag like
sources: Booleanwith defaultvalue true then there was no way for cli users to set the value to
false because
--sourcescan only set the boolean to true. Now, userscan pass the flag
--no-sourcesto make the boolean value false.This diff ended up being trickier to implement than I expected because
we need to make sure that it's still OK to name fields with a
--no-prefix, such as
noSources: Boolean. This feature is implemented in afully backwards compatible way by always trying first to use the default
parsing logic and only falling back to guessing the addition or removal
of the
--no-prefix. This means that a boolean flag namednoSources: Booleancan also be overriden with the--sourcesflag.