-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show Metals' release notes if server version is updated #1009
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea! 🎉 It would be similar to the VS Code updates that show up, which are really nice to check out. The main difficulty will be to make sure that we don't show it too often.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think PR is ready for review & testing.
Tests:
- MacOS - done by me
- Linux
- Windows (not sure how it'll work with wsl)
- remote containers (gitpod, codespaces) - I read that they start from scratch every time, better to not show release notes at all than show them every time
- synchronization between editors on local computer - release notes are showed only in first vscode instance, subsequent windows don't get them
- synchronization between devices - not necessary but nice to have & should work
@kpodsiad Thanks for kicking off, this is a great idea! I remember GitLens extension shows a welcome/what's the new view if there're updates, so I checked how it is implemented.
|
@tgodzik I've increased margin for headers, it should be better now. |
The change looks good to me! Let me playing around this change a bit :) |
I think |
Great idea @Arthurm1. I can both command and button in 'Help and Feedback'. |
I've added a command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Let's just rebase on the main branch
I'm merging, pre-release it's time to do your job :D |
scalameta#1009)" This reverts commit 3ebbea7.
I reverted the PR in #1019 since it seems to have broke Metals at all. |
…s updated (scalameta#1009)"" This reverts commit 6c66438.
Motivation
Currently Metals updates are completely silent and I suspect that most of the users doesn't even know that update just happened. Not everyone has twitter account or is checking Metals' blog on regular basis and this kind of people (I suspect that most of the beginners?) can omit all of those juicy new features which are shipped with the new release.
It is a goal of this PR to provide some mechanism to inform user about latest changes.
Other solutions
Currently, as far as I know, there is no mechanism for showing extension updates in vscode - see microsoft/vscode#102139. There are some ways to do it, for example I found https://github.com/alefragnani/vscode-whats-new but it seems like its use case is a bit different than what this PR needs (metals-vscode doesn't have any useful changes on its own).
Goals
Show some indicator that update happened, maybe show embedded release notes in the webview panel?
No matter what indicator will be chosen it mechanism should:
Current state