Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump metals-languageclient to 0.5.17 and vscode-languageclient to 8.0.2 #1063

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

tanishiking
Copy link
Member

Previously, we reverted the updates to those libraries in #1018 because of the issue.

Now, the fix for the cause is in vscode-languageclient 8.0.2 and we should be able to safe to update those libraries.

I'm going to play around with this build for a while before merging this PR :)

Previously, we reverted the updates to those libraries in
scalameta#1018
because of the
[issue](scalameta#1016).
Now, the fix for the cause is in
vscode-languageclient 8.0.2 and we should be able to safe to update
those libraries.
PR: microsoft/vscode-languageserver-node#972
release note: https://github.com/microsoft/vscode-languageserver-node#3172-protocol-802-json-rpc-802-client-and-802-server
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking care of it!

@tanishiking
Copy link
Member Author

I played around with this build for a while and I didn't see any issue with it 🎉

@tanishiking tanishiking merged commit 8b5e23c into scalameta:main Jul 14, 2022
@tanishiking tanishiking deleted the bump-languageclients branch July 14, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants