Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: Search PATH for Java to use #1486

Merged
merged 2 commits into from
Apr 25, 2024
Merged

improvement: Search PATH for Java to use #1486

merged 2 commits into from
Apr 25, 2024

Commits on Apr 21, 2024

  1. improvement: Search PATH for Java to use 

    Previously, we would rely on the separate library for detecting java, but we had no control on whether it worked and it doesn't seem actively used by a lot of people.

Now, we first check JAVA_HOME and then search PATH for the actual Java to use. If we can't find any of that we download ourselves. This seems simple enought logic.
    @tgodzik
    tgodzik committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    f82b387 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. tests: Add real tests for detecting Java

    @tgodzik
    tgodzik committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    892e8bc View commit details
    Browse the repository at this point in the history