feature: Also run plain Java when noDebug from launch.json #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if user run code from code lenses they would get a java command running without DAP. However, if they wanted to add parameters and run via launch.json they would run it via DAP. Now, even if running from configuration we will run with simple java command. One issue here is that we need to start debugger anyway of run via launch.json, but I worked around it by just running echo instead.
|
This should be good to review now. |
|
But scalameta/metals#6306 was merged after the release. Or do you mean just so it's reviewed? |
|
I just meant if you could take a look at it, no pressure. Will include it in the next release. |
kasiaMarek
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if user run code from code lenses they would get a java command running without DAP. However, if they wanted to add parameters and run via launch.json they would run it via DAP.
Now, even if running from configuration we will run with simple java command. One issue here is that we need to start debugger anyway of run via launch.json, but I worked around it by just running echo instead.
Needs scalameta/metals#6306