Change the non-fatal jar error to debug rather than log warning #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
approved these changes
Jan 20, 2020
|
Test failure seems like a fluke and unrelated since it was with resolving dependencies and only happened in the ubuntu jdk8 test. |
Yeah, aside of flaky tests we are getting flaky downloads recently :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1304
This will fix the warning that users are getting for example about a missing
/Usersdirectory or other superfluous warnings coming from non fatal errors when we scan the jar files.I went ahead and changed this to debug which was mentioned in the issue. If there is a scenario where you think this isn't ideal, what would that scenario be, and what is an alternative way to do this?