Upgrade to Scalameta 3.2.0 #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
reviewed
Feb 2, 2018
| // TODO(olafur) handle local symbols on the fly from a `Document` in go-to-definition | ||
| // local symbols don't need to be indexed globally, by skipping them we should | ||
| // def isLocalSymbol(sym: String): Boolean = | ||
| // !sym.endsWith(".") && | ||
| // !sym.endsWith("#") && | ||
| // !sym.endsWith(")") | ||
| // be able to minimize the size of the global index significantly. | ||
| // case s.ResolvedName(_, sym, _) if isLocalSymbol(sym) => // Do nothing, local symbol. | ||
| case s.ResolvedName(Some(s.Position(start, end)), sym, true) => | ||
| // case s.SymbolOccurrence(_, sym, _) if isLocalSymbol(sym) => // Do nothing, local symbol. |
There was a problem hiding this comment.
The changes for local symbols will require us to implement this TODO. Local symbols must now either use reference equality or include the original document in their syntax because two local symbols from different source files can have identical structures.
laughedelic
reviewed
Feb 4, 2018
| if (ptest(p.COVARIANT.value)) mflip(m.COVARIANT) | ||
| if (ptest(p.CONTRAVARIANT.value)) mflip(m.CONTRAVARIANT) | ||
| flags | ||
| } |
There was a problem hiding this comment.
I'm not sure what is happening here and why this huge if-else chain is necessary 🤔
olafurpg
requested changes
Feb 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some test failures, but I wanted to submit anyway, because I'm not exactly sure how many of those are the consequence of having incompatible Scalafix on the classpath (see scalacenter/scalafix#595 for the Scalafix upgrade pull request).