navigate to decompiled class if no source #3411
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial stab at scalameta/metals-feature-requests#210
I've no idea whether this is done in the correct area of code but it works so 🤷. If it is the correct area then I'll follow up with some tests.
One thing I've noticed is that
scala.meta.internal.mtags.SymbolDefinition
(and a number of other classes used for passing file locations around) useAbsolutePath
to refer to file locations. This is handy becausenio.Path
validates that the format is correct and there are lots of useful Path methods but it's not so handy when all that's really going on is URIs are being passed around.Downsides of using AbsolutePath are that any
jar:file///somejar.jar!/someclass.java
style reference has to be opened in javaFileSystems#newFileSystem
, even if you're not accessing it, or it throws an exception. Also - you can't use a virtual URI e.g.metalsDecode:jar:file:///somejar.jar!/someclass.class.cfr
in AbsolutePath because it wrapsnio.Path
and I've not implemented ametalsDecode
filesystem as I think that's over the top.Is there a reason for using AbsolutePath rather than URI in all these places - or is it just historical?