Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala 3 type completion #4174

Merged
merged 17 commits into from
Aug 1, 2022
Merged

Scala 3 type completion #4174

merged 17 commits into from
Aug 1, 2022

Commits on Aug 1, 2022

  1. filtering out invalid trait, object, class, import, or apply method c… 

    …ompletions according to position for scala 3.

adding square bracket suffix where relevant for type, new, and instantiation completions, for scala 3.
adding curly brace suffix in new completions of trait, abstract, java interface types for scala 3.
    @vzmerr
    vzmerr committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    9fd7715 View commit details
    Browse the repository at this point in the history

  2. preventing duplicate bracket insertion 

    adjust CompletionInterpolatorSuite and CompletionWorkspaceSuite
    @vzmerr
    vzmerr committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    c78538f View commit details
    Browse the repository at this point in the history

  3. adjusting the CompletionWorkspaceSuite and CompletionSuite for Scala 2

    @vzmerr
    vzmerr committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    91a31e0 View commit details
    Browse the repository at this point in the history

  4. ignore "3.2.0-RC1" up to "3.2.1" for the failing interpolator suite t… 

    …ests.
    @vzmerr
    vzmerr committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    c6846e9 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Tomasz Godzik <tgodzik@users.noreply.github.com>
    @vzmerr @tgodzik
    vzmerr and tgodzik committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    d073ff1 View commit details
    Browse the repository at this point in the history

  6. renamings from review

    @vzmerr
    vzmerr committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    a72befb View commit details
    Browse the repository at this point in the history

  7. turn type completion variables into immutable values

    @vzmerr
    vzmerr committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    82e2651 View commit details
    Browse the repository at this point in the history

  8. handling the insertion of cursor position

    @vzmerr
    vzmerr committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    967f7bd View commit details
    Browse the repository at this point in the history

  9. usage of Flags instead of toString for object and methods

    @vzmerr
    vzmerr committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    f93fe81 View commit details
    Browse the repository at this point in the history

  10. removed unnecessary compat maps for Scala3

    @vzmerr
    vzmerr committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    87b6970 View commit details
    Browse the repository at this point in the history

  11. Applying filtering without enrichWithSymbolSearch on interpolate comp… 

    …letions results
    @vzmerr
    vzmerr committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    198bfa3 View commit details
    Browse the repository at this point in the history

  12. refactoring the suffix and filtering logic in CursorPositionCondition

    @vzmerr
    vzmerr committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    3af9166 View commit details
    Browse the repository at this point in the history

  13. test empty parameter list with an implicit param for braces insertion

    @vzmerr
    vzmerr committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    12a127a View commit details
    Browse the repository at this point in the history

  14. linking the dotty issue of trees after typer losing information for h… 

    …asNoSquareBracket calculation
    @vzmerr
    vzmerr committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    81d989e View commit details
    Browse the repository at this point in the history

  15. Apply suggestions from code review 

    Co-authored-by: Kamil Podsiadło <37124721+kpodsiad@users.noreply.github.com>
    @vzmerr @kpodsiad
    vzmerr and kpodsiad committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    82482b1 View commit details
    Browse the repository at this point in the history

  16. excluding abstract methods for {} insertion 

    correct detection of traits
    @vzmerr
    vzmerr committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    5de87b2 View commit details
    Browse the repository at this point in the history

  17. allowing method traits in method call pos

    @vzmerr
    vzmerr committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    d0bc467 View commit details
    Browse the repository at this point in the history