[WIP] Import missing given instance #4177
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refer to scalameta/metals-feature-requests#141
This PR enables us to import missing given instance
TODO
There're some limitations:
stringOrd: Ord[String]
, we will receive suggestions both forintOrd
andstringOrd
, I'm wondering can we filter it with a reasonable computation cost 🤔lt
andgt
because they're not under given instances.