feat: add setting to choose preferred build server #6121
Conversation
| @@ -570,6 +587,11 @@ object UserConfiguration { | |||
| case _ => AutoImportBuildKind.Off | |||
| } | |||
|
|
|||
| val scalaCliLauncher = getStringKey("scala-cli-launcher") | |||
There was a problem hiding this comment.
I added this because it seems to me it should be there but maybe there was some great scheme behind not adding this that I'm not aware of.
|
I hope I'm not too late on this seeing that you're already pretty far, but I think that instead of providing a list of preferred build servers we should instead just provide a setting like "default BSP to build tool". (In the comment we can say "defaults to bloop") I would much rather just mark that as true to ensure that when I'm using sbt, it defaults to sbt and when using Mill it defaults to Mill. Then users don't need to think about any list or what they should include in it. I have a feeling that this would accomplish what most users want while providing a simpler UI. wdyt? |
The use-case I had in mind was: |
ckipp01
added
the
affects clients
| ): ShowMessageRequestParams = { | ||
| val params = new ShowMessageRequestParams() | ||
| params.setMessage( | ||
| s"New $buildToolName workspace detected, would you like connect to $buildServerName build server?" |
There was a problem hiding this comment.
| s"New $buildToolName workspace detected, would you like connect to $buildServerName build server?" | |
| s"New $buildToolName workspace detected, would you like connect to the $buildServerName build server?" |
Nit
| "default-bsp-to-build-tool", | ||
| "false", | ||
| "true", | ||
| "If used build server should default to build tool.", |
There was a problem hiding this comment.
| "If used build server should default to build tool.", | |
| "Default to using build tool as your build server.", |
| """|If used build server should default to the one provided by the build tool | ||
| |instead of the default Bloop. |
There was a problem hiding this comment.
| """|If used build server should default to the one provided by the build tool | |
| |instead of the default Bloop. | |
| """|If your build tool can also serve as a build server, default to using it instead of Bloop. |
resolves: scalameta/metals-feature-requests#358