Update all the things for 0.6 #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change for anyone that was overriding handlers in the old 0.5 way of doing them. Please see this for more details: neovim/neovim#15504 Keep in mind that the new format for hanlders is: ``` function(err, result, context, config) ```
This may be a breaking change for some.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: That when this pr is merged, 0.6 will be the new required default for
nvim-metals.vim.fn.input->vim.ui.inputvim.fn.inputlist->vim.ui.select(NOTE: We won't be able to use this.)So we ended up not being able to use
vim.ui.selectwhere I thought we'd be able to. It's not recommended to use it in places were a return value is needed since it's call back based. The tricky part is that the default implementation in core is blocking, so it will work here, but then when you using an async plugin like telescope, it won't work. Since it's not safe to use that there we don't use it. Same goes withvim.ui.inputin places where a return values us needed, like in a LSP server request.