Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add inlay hints setting #689

Merged
merged 2 commits into from
Sep 16, 2024
Merged

feat: add inlay hints setting #689

merged 2 commits into from
Sep 16, 2024

Conversation

gAbelli
Copy link
Contributor

@gAbelli gAbelli commented Sep 14, 2024

Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @gAbelli! Since we're moving this into inlayHints like they're supposed to be we can also remove the following:

    showImplicitArguments = true,
    showImplicitConversionsAndClasses = true,
    showInferredType = true,

They no longer need to be their own valid keys. While from the looks of it in Metals they are still supported lets only advertise a single (new) way of doing this.

@gAbelli
Copy link
Contributor Author

gAbelli commented Sep 16, 2024

I agree, I dropped them from the documentation but I kept them among the valid settings for backwards compatibility

Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ckipp01 ckipp01 merged commit c2aed75 into scalameta:main Sep 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants