Add sbt-vspp for publishing the SBT plug-in in a Maven-consistent format #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to enable usage of sbt-scalafmt in Enterprise environments where only the valid-POM format is accepted for JAR downloads, enabling advanced Scala capabilities for many many environments. Currently the only way to use it is by manual republishing but we rather any updates get made available automatically. The only change this does is to add extra JAR and POM to the released artifact (while keeping the old structure -- notice how when you click on 'Browse' on here https://search.maven.org/artifact/org.scalameta/sbt-scalafmt/2.4.6/jar - it goes to a 404 Not Found page. More background here: https://github.com/esbeetee/sbt-vspp/blob/main/README.md
|
@kitbellew we already took it into bloop so in general PR is fine. The only issue is that scripted test fails with some binary-incompatibility error. |
Thanks for pointing out @dos65. Might be the SBT version vspp is linked against. I'll check later to fix this in a new version. |
ScalaWilliam
added a commit
to esbeetee/sbt-vspp
that referenced
this pull request
Aug 1, 2022
Reported via scalameta/sbt-scalafmt#234 (comment) Error is here: https://github.com/scalameta/sbt-scalafmt/runs/7604602427?check_suite_focus=true When SBT processes the `if()`, it seems to have been updated more recently, ie does not work with SBT 1.2.6 for example.
ScalaWilliam
added a commit
to esbeetee/sbt-vspp
that referenced
this pull request
Aug 1, 2022
Reported via scalameta/sbt-scalafmt#234 (comment) Error is here: https://github.com/scalameta/sbt-scalafmt/runs/7604602427?check_suite_focus=true When SBT processes the `if()`, it seems to have been updated more recently, ie does not work with SBT 1.2.6 for example.
|
Reproduced it - will fix in due course. This is because an SBT 1.6 build refers to settings that are not there in SBT 1.2.x |
|
hi @dos65 this is fixed now, would you be able to review it again? |
ckipp01
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Hope you don't mind me making this PR to request to publish Maven-consistent format of this plugin alongside the existing artifact format.
This is to enable usage of sbt-scalafmt in Enterprise environments where only the valid-POM format is accepted for JAR downloads, enabling advanced Scala capabilities for many many environments. Currently the only way to use it is by manual republishing but we rather any updates get made available automatically.
The only change this does is to add extra JAR and POM to the released artifact (while keeping the old structure) -- notice how currently when you click on 'Browse' on here https://search.maven.org/artifact/org.scalameta/sbt-scalafmt/2.4.6/jar - it goes to a 404 Not Found page -- this is because of the inconsistent / invalid POM.
More background here: https://github.com/esbeetee/sbt-vspp/blob/main/README.md