Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scalatags to 0.9.4 #2387

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Update scalatags to 0.9.4 #2387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,10 +207,7 @@ lazy val tests = project
skip in publish := true,
libraryDependencies ++= Seq(
// Test dependencies
CrossVersion.partialVersion(scalaVersion.value) match {
case Some((2, 13)) => "com.lihaoyi" %% "scalatags" % "0.9.3"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know why we had a split? what does the commit message say, if you use git blame?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it was introduced while adding support for 2.13 #1522

Doesn't seem there is any particular reason other than maybe it was only released for 2.13?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last question. should we keep this check for 2.13 and just update its version? just in case the next version of scalatags will once again not support an older version of scala, and we won't need to remember how to write this construct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think they should soon start to stop supporting it, but we have this construct all over the place in Metals and I think this is also done for parallel-collections https://github.com/scalameta/scalafmt/blob/master/build.sbt#L119

case _ => "com.lihaoyi" %% "scalatags" % "0.9.4"
},
"com.lihaoyi" %% "scalatags" % "0.9.4",
"org.typelevel" %% "paiges-core" % "0.3.0",
scalametaTestkit,
munit.value
Expand Down