Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormatOps: use keep in binPackParentCtorSplits #2452

Merged
merged 4 commits into from
Apr 28, 2021

Conversation

kitbellew
Copy link
Collaborator

Refactor splitWithChain into binPackParentConstructorSplits, automatically determine the intermediate or final expiration for inits or derives in a template.

That allows modifying a single rule to preserve existing breaks (in newlines.source=keep).

Fixes #2226.

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a small comment, feel free to ignore, but might be useful for future readability.

@kitbellew kitbellew merged commit 0019be8 into scalameta:master Apr 28, 2021
@kitbellew kitbellew deleted the 2226 branch April 28, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to prevent adding a newline before extends?
2 participants