-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docstrings.forceBlankLineBefore
, remove parameters deprecated before v3.0.0
#3081
Conversation
Also, remove old `optIn.blankLineBeforeDocstring` and deprecate its replacement `optIn.forceBlankLineBeforeDocstring`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one comment.
): Seq[DanglingParentheses.Exclude] = | ||
exclude.getOrElse { | ||
if (!isVerticalMultiline) Nil | ||
else DanglingParentheses.Exclude.defaultVerticalMultiline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that the new parameter is empty by default while the old one
contained `[class, trait]`.
Is this indeed the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean, remove that phrase since we take care of the default internally? yeah...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved to the other section, mentioned that the default depends on whether vertical multiline is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
No description provided.