Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docstrings.forceBlankLineBefore, remove parameters deprecated before v3.0.0 #3081

Merged
merged 4 commits into from
Jan 26, 2022

Conversation

kitbellew
Copy link
Collaborator

No description provided.

Also, remove old `optIn.blankLineBeforeDocstring` and deprecate its
replacement `optIn.forceBlankLineBeforeDocstring`.
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment.

): Seq[DanglingParentheses.Exclude] =
exclude.getOrElse {
if (!isVerticalMultiline) Nil
else DanglingParentheses.Exclude.defaultVerticalMultiline
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 that the new parameter is empty by default while the old one
contained `[class, trait]`.

Is this indeed the case?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean, remove that phrase since we take care of the default internally? yeah...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to the other section, mentioned that the default depends on whether vertical multiline is used.

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kitbellew kitbellew merged commit 7911a86 into scalameta:master Jan 26, 2022
@kitbellew kitbellew deleted the 3082 branch January 26, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants