Fix early initializers #3091
Fix early initializers #3091
Conversation
| object CoreReflection extends { | ||
| val u: ru.type = ru | ||
| val mirror: u.Mirror = | ||
| u.runtimeMirror(classOf[scala.meta.Tree].getClassLoader) | ||
| } with scala.meta.internal.trees.Reflection | ||
| with scala.meta.internal.tokens.Reflection |
There was a problem hiding this comment.
Without this fix it's formatted as:
object CoreReflection
extends {
val u: ru.type = ru
val mirror: u.Mirror = u.runtimeMirror(classOf[scala.meta.Tree].getClassLoader)
}
with scala.meta.internal.trees.Reflection
with scala.meta.internal.tokens.Reflection
There was a problem hiding this comment.
actually, i would think this new formatting is NOT desirable. why is extends treated differently than with?
how is this formatted:
object CoreReflection
extends Foo(
bar,
baz
)
with scala.meta.internal.trees.Reflection
with scala.meta.internal.tokens.Reflection
There was a problem hiding this comment.
From what I see, currently the logic is designed for the case of extends-with chain and then template body.
The early-init is a different case - there is a body between extends and with chain.
I think it would be better to support this construction if the required amount of changes is similar to what I proposed. That's the style how they were used + Scalafmt 2 worked worked well with it + migration to 3 triggers unwanted reformat.
There was a problem hiding this comment.
see #3094, it does something similar but consistent with configuration. the difference is indentation.
| object CoreReflection extends { | ||
| val u: ru.type = ru | ||
| val mirror: u.Mirror = | ||
| u.runtimeMirror(classOf[scala.meta.Tree].getClassLoader) | ||
| } with scala.meta.internal.trees.Reflection | ||
| with scala.meta.internal.tokens.Reflection |
There was a problem hiding this comment.
actually, i would think this new formatting is NOT desirable. why is extends treated differently than with?
how is this formatted:
object CoreReflection
extends Foo(
bar,
baz
)
with scala.meta.internal.trees.Reflection
with scala.meta.internal.tokens.Reflection
|
also, even if we consider this, shouldn't we use |
| @@ -856,7 +856,9 @@ object TreeOps { | |||
| } | |||
|
|
|||
| def getStartOfTemplateBody(template: Template): Option[Token] = | |||
| template.self.tokens.headOption | |||
| template.early.headOption | |||
There was a problem hiding this comment.
this function must return the token which starts the body of the class/trait/object, not before that
| if (template.early.nonEmpty) { | ||
| val expire = template.inits.last.tokens.last | ||
| Seq( | ||
| Split(Space, 0).withIndent(1, expire, ExpiresOn.After), |
There was a problem hiding this comment.
indent 1? what does this even do?
No description provided.