Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State: correctly compute line widths in strings and interpolations with strip margin #3095

Merged
merged 3 commits into from
Feb 2, 2022
Merged

State: correctly compute line widths in strings and interpolations with strip margin #3095

merged 3 commits into from
Feb 2, 2022

Conversation

kitbellew
Copy link
Collaborator

Fixes #3090.

  • For strings, didn't use the parameter to .stripMargin call to detect the right strip margin character.
  • For interpolations, didn't handle strip margin at all

tgodzik
tgodzik approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kitbellew kitbellew merged commit 9731c28 into scalameta:master Feb 2, 2022
@kitbellew kitbellew deleted the 3090 branch February 2, 2022 14:47
@vlad107 vlad107 mentioned this pull request Apr 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

@dos65 dos65 Awaiting requested review from dos65

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scalafmt is not idempotent
2 participants
@kitbellew @tgodzik