Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scala-library, scala-reflect to 2.13.12 #3649

Closed
wants to merge 1 commit into from

Conversation

scalameta-bot
Copy link
Contributor

About this PR

πŸ“¦ Updates

from 2.13.11 to 2.13.12

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-lang" }
}]
labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

@kitbellew
Copy link
Collaborator

can't merge it, since we load older versions dynamically and some of them will throw NoSuchElementException when accessing the last token of a now-empty Tokens slice (which has generally been fixed in more recent versions). cc @tgodzik.

@kitbellew kitbellew closed this Oct 2, 2023
@kitbellew kitbellew deleted the update/scala-library-2.13.12 branch October 2, 2023 21:00
@tgodzik
Copy link
Contributor

tgodzik commented Oct 3, 2023

since we load older versions dynamically

But older versions would use the new Scala version, not the old one?

@kitbellew
Copy link
Collaborator

older versions would indeed use the new scala version. the problem is, older versions had the same problem as the one mentioned in scalameta/scalameta#3235, and while the problem was fixed later, due to dynamic loading, if we switch scalafmt to this new scala version, and someone uses it to load an older version dynamically, it will fail.

although, i guess, if they are using an old version of the formatter in their .scalafmt.conf, why would they upgrade the executable version?

@tgodzik
Copy link
Contributor

tgodzik commented Oct 3, 2023

although, i guess, if they are using an old version of the formatter in their .scalafmt.conf, why would they upgrade the executable version?

I have seen it the other way, but not really the case where the executable would be newer. I guess if someone installs it globally then this might happen for an older project. I wonder if there would be a way to use older version of scala. We do use a custom classloader if I remember?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants