Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed example line limit to agree with Intellij default and industr… #3707

Closed
wants to merge 1 commit into from

Conversation

samthebest
Copy link

The reason why 120 has long been the ubiquitously accepted convention is because Intellij IDE has been the longest ubiquitously accepted IDE for Scala, which came prior to scalafmt and which picks a default of 120 characters.

There are roughly 170 OS repositories that use 120 given by this approximate search: https://github.com/search?q=maxColumn+%3D+120&type=commits

Then about 33 for length 100 https://github.com/search?q=maxColumn+%3D+100&type=commits

@kitbellew
Copy link
Collaborator

@samthebest please stop this.

@kitbellew kitbellew closed this Nov 24, 2023
@scalameta scalameta locked as too heated and limited conversation to collaborators Nov 27, 2023
@tgodzik
Copy link
Contributor

tgodzik commented Nov 27, 2023

@samthebest Please respect the maintainers' decision. @kitbellew is the main contributor, who does the majority of work here (like 99%), so I trust him to make a proper decision. I don't think it's worth you time and effort.

What would probably be better is raising a post on contributors discussing what would be the best starting configuration, which we would be able to put into recommendation at the start here.

@tgodzik
Copy link
Contributor

tgodzik commented Nov 27, 2023

I raised a PR to make it more explicit that you should not use example configuration #3710

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants