RemoveScala3OptionalBraces: allow leading infix op #3840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we didn't allow it as the scalameta library didn't provide a way to check when it was actually possible.
tgodzik
reviewed
Mar 16, 2024
| judgment.toString | ||
| } + "." | ||
| this.match | ||
| case MateAdvice(seq, _, _, _) => |
There was a problem hiding this comment.
Why do we have 3 spaces here? It should stay the same, no?
There was a problem hiding this comment.
because significant indentation in this file is set to 3:
tgodzik
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we didn't allow it as the scalameta library didn't provide a way to check when it was actually possible. Helps with #3812.