Add literal.binPrefix setting to format binary literals. #4183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those are of the form 0b111 or 0b111L and so are susceptible to both literals.binPrefix and literals.long.
kitbellew
requested changes
Aug 23, 2024
|
I've added the version number and made the suggested code changes. |
kitbellew
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add formatting to handle binary literals, which were added in Scala 3.5.0.
Those are of the form 0b111 or 0b111L and so are susceptible to both literals.binPrefix and literals.long.
The 3.5.0 release uses 0B111 in its examples, but the original SIP 42 uses 0b111. I chose 0b as the default, as it looks a lot nicer to me.
There is a new test file (
binary.stat) and the documentation was updated (it's missing asincecomment).The changes address my own feature request: fixes #4176.