RemoveScala3OptionalBraces: () to fewer braces
#4515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also test apply with parens to be rewritten to fewer-braces.
tgodzik
approved these changes
Nov 7, 2024
| @@ -3853,6 +3853,11 @@ The section contains the following settings (available since v3.8.1): | |||
| - will only apply the rewrite if the cumulative span of all visible | |||
| (non-whitespace) tokens within the argument is between the two values | |||
| - this rule is disabled if `fewerBracesMaxSpan == 0` | |||
| - (since v3.8.4) `fewerBracesParensToo` | |||
There was a problem hiding this comment.
Suggested change
| - (since v3.8.4) `fewerBracesParensToo` | |
| - (since v3.8.4) `alsoParens` |
wouldn't be enough? Since it's already removeOptionalBraces.fewerBracesParensToo
There was a problem hiding this comment.
will that not be confusing? it only works for fewer braces, not for any other potential case involving optional braces.
There was a problem hiding this comment.
Ach right, mit be confusing. Nevermind then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.