refactor: Use Scala Native instead of native image #4738
Conversation
tgodzik
force-pushed
the
build-scala-native
branch
5 times, most recently
from
006a710 to
edcfb8e
Compare
|
Looks like it's simpler than I thought. I also added windows and macos runners. |
|
I wonder if we should be so strict with the version incompatibility? Maybe we should allow version of the image higher than the version in the config? |
where does this come into play? |
We have a check for scala native that if the version of the binary is different than the one in config it will throw an exception. |
I wouldn't do that. we must use the version specified in the config file, that's the contract. how is "higher version" better than "lower version"? both can produce a slightly different formatting, even if higher likely won't fail on newer configuration parameters. |
tgodzik
force-pushed
the
build-scala-native
branch
from
edcfb8e to
ceaffc4
Compare
tgodzik
force-pushed
the
build-scala-native
branch
2 times, most recently
from
8be93ac to
5ea40da
Compare
tgodzik
force-pushed
the
build-scala-native
branch
from
5ea40da to
d18fa6e
Compare
|
|
||
| For macOS and Linux, it's possible to download pre-built GraalVm native binaries | ||
| with instant startup and fast performance for short-lived Scalafmt runs. | ||
| It's possible to download pre-built Scala Native binaries |
There was a problem hiding this comment.
This might be controversial, but I feel like fixing the install-scalafmt-native.sh is a lot more work and scala cli already properly downloads binaries.
There was a problem hiding this comment.
And also on all platforms
There was a problem hiding this comment.
that sounds good to me, no duplication
| curl https://raw.githubusercontent.com/scalameta/scalafmt/master/bin/install-scalafmt-native.sh | \ | ||
| bash -s -- $VERSION $INSTALL_LOCATION | ||
| scalafmt-native --help # should show version @STABLE_VERSION@ | ||
| scala-cli format |
There was a problem hiding this comment.
This will read the scalafmt version if it exists and download the proper binary. We will need to update it and drop the additional repository, but it should be a smooth transition.
|
|
||
| For macOS and Linux, it's possible to download pre-built GraalVm native binaries | ||
| with instant startup and fast performance for short-lived Scalafmt runs. | ||
| It's possible to download pre-built Scala Native binaries |
There was a problem hiding this comment.
that sounds good to me, no duplication
tgodzik
force-pushed
the
build-scala-native
branch
from
a5daa5b to
70da3bd
Compare
tgodzik
force-pushed
the
build-scala-native
branch
from
70da3bd to
b902291
Compare
| uses: graalvm/setup-graalvm@v1 | ||
| with: | ||
| fetch-depth: 0 | ||
| - uses: actions/setup-java@v4 |
There was a problem hiding this comment.
a comment for separate consideration: if we are using java 21 for this, should we disable java 8 compatibility in native builds (if they apply, that is)?
There was a problem hiding this comment.
We can, but the main difference would be that we could use some method from newer JDKs for the native code itself. Not sure it's worth it really. I've put JDK 21, but that might not matter also. Just picked newest LTS
|
@tgodzik somehow didn't occur to me... should we restore native image for now and keep both until all possible kinks have been ironed out? |
|
We can add the script back so that people can migrate, though I would recommend using Scala CLI in that case. For the script to work with the new setup we would have to support windows etc. Alternatively, I can make the script work with the new setup as well only for those systems that it used to work for. |
|
apparently, people are saying (on discord) that scala-cli doesn't work. yet, at least. so, in order to avoid disruptions to existing setups, should we restore what we had before, in addition to the new stuff, and remove it later, when we've confirmed everything is working for everyone? |
I did a fix for Scala CLI, forgot to publish the latest binaries. It's running now https://github.com/VirtusLab/scalafmt-native-image/releases/tag/v3.8.6 And added the script back, so that should also restore things for now. I can add a warning maybe for newer versions to use SCala CLI? I will make sure the releases are on time and migrate soon to the original binaries here |
We could notate that native image will be removed in early 2025. |
Fixes #4729