-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
semanticdb-scalac + scalamacros/paradise break Scaladoc generation #1072
Comments
It seems semanticdb-scalac conflicts with scalamacros/paradise under ScaladocGlobal. See scalameta#1072.
It seems semanticdb-scalac conflicts with scalamacros/paradise under ScaladocGlobal. See scalameta#1072.
This is increasingly annoying since it's blocking me from using scalafix for development in both the scalameta and scalafix repos. Any idea what might be causing this @xeno-by ? |
Does the issue only occur when paradise is enabled? |
Yes, scalamacros/paradise annotations are not expanded causing compile errors. |
Scalamacros/paradise doesn't do any analyzer hijacking, at least not on Scala 2.11+. Instead, it installs so-called analyzer and macro plugins: https://github.com/scalamacros/paradise/blob/2.12.3/plugin/src/main/scala/org/scalamacros/paradise/Plugin.scala#L14-L15. If I were to guess, I'd say that semanticdb hijacking replaces the analyzer with the paradise plugins installed with the new analyzer that doesn't have these plugins anymore. Why this happens only under scaladoc - that's not immediately obvious. |
We could skip hijack under ScaladocGlobal. Unlike scalameta/paradise, the sources compile fine withouth semanticdb enabled. |
I opened #1095 to fix this. |
Disable hijacking under ScaladocGlobal, fix #1072.
At the following commit
scalacenter/scalafix@9798839
I have the scalahost compiler plugin enabled in the scalafix repo
coreJVM/compile
is OKcoreJVM/doc
fails, build failures https://travis-ci.org/scalacenter/scalafix/jobs/265876123#L698The problems seems related to scalamacros/paradise, the following macro annotations in the same projects are not expanded under scaladoc https://github.com/scalacenter/scalafix/blob/016d01cc0286f555bad3ecd898a23ade637786d4/scalafix-core/shared/src/main/scala/scalafix/util/TokenClasses.scala#L7
@xeno-by could analyzer hijacking be conflicting with scalamacros/paradise analyzer hackery under scaladocglobal?
Disabling semanticdb-scalac fixes the problem.
The text was updated successfully, but these errors were encountered: