This repository has been archived by the owner on Apr 7, 2018. It is now read-only.
Upgrade to Scalameta 3.0.0 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build did not trigger recompilation of test inputs when changing the compiler plugin.
olafurpg
approved these changes
Feb 2, 2018
| private def line(offset: Int): Int = { | ||
| // NOTE: Looks like some seriously crazy stuff is going on here. | ||
| // source.offsetToLine(offset) | ||
| 0 |
There was a problem hiding this comment.
I expanded on "crazy stuff" and included a comment explaining why this hack works for scala.meta.Position but is incompatible with how LSP treats line/character pairs.
There was a problem hiding this comment.
In LSP, characters=Int.MaxValue falls back to the last character in the line https://microsoft.github.io/language-server-protocol/specification#position
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.