Java 10 not recognized

[lostiniceland]

Running ScalaPB with Java 10 result in the following error

The java installation you have is not up to date
requires at least version 1.6+, you have
version 10.0.1

Probably the new version-scheme isnt recognized.

[thesamet]

Hi @lostiniceland - can you add more details? Do you use SBT? Does SBT load? If so, at what stage does this message get printed?

[lostiniceland]

No, not using SBT, my projects are based on Gradle right now. I am actually generating the file via a little shell-script with ScalaPB and Protoc on my path

scalapbc --scala_out=flat_package:build/generated/source/proto/main/java src/main/proto/my.proto

[thesamet]

To clarify, are you getting the error you posted above when you attempt to run scalapbc ?

[lostiniceland]

yes

marc@Tux:~/Development/git/myproject$ java -version
openjdk version "10.0.1" 2018-04-17
OpenJDK Runtime Environment (build 10.0.1+10)
OpenJDK 64-Bit Server VM (build 10.0.1+10, mixed mode)
marc@Tux:~/Development/git/myproject$ scalapbc --scala_out=flat_package:build/generated/source/proto/main/java src/main/proto/my.proto

The java installation you have is not up to date
requires at least version 1.6+, you have
version 10.0.1

Please go to http://www.java.com/getjava/ and download
a valid Java Runtime and install before running .

[xuwei-k]

• https://github.com/sbt/sbt-launcher-package/blob/d76459db699ab36d0d05418c8a8993c0e95822fa/src/universal/bin/sbt-launch-lib.bash#L241-L246
• Handle JDK 10 version string sbt/sbt-launcher-package#209
• more portable jdk_version function sbt/sbt-launcher-package#219
• Fix Java version detection and comparison for JDK 10 sbt/sbt-launcher-package#225
• Changed references to downloading/installing/updating Java (JRE?) to … sbt/sbt-launcher-package#195

use old sbt🤔 ?

[thesamet]

I wasn't able to reproduce this problem. Here is what I did:

docker run --rm -ti openjdk:10-jdk /bin/bash

wget https://github.com/scalapb/ScalaPB/releases/download/v0.7.4/scalapbc-0.7.4.zip

unzip scalapbc-0.7.4.zip 

./scalapbc-0.7.4/bin/scalapbc 
[normal output]

Can you provide a way to reproduce this problem, ideally in a docker container?

[thesamet]

I was able to reproduce this in Ubuntu 18.04. Upgrading sbt-native-package resolved this issue.

[lostiniceland]

Thanks for your effort to reproduce (due to vacation I couldnt provide it myself). I will give it a test-drive later.

EDIT: @thesamet how can I package the binary distribution? I was able to build with sbt but now I need to replace the individual jar-files in my current installation and there seems to be some refactorings (moved packages from "com.thesamet...").