Skip to content
This repository has been archived by the owner on Apr 25, 2021. It is now read-only.

Handle JDK 10 version string #209

Merged
merged 1 commit into from
Feb 5, 2018
Merged

Conversation

2m
Copy link
Member

@2m 2m commented Feb 3, 2018

JDK 10 version string does not end with a " anymore which broke the regexp and sbt launcher would not even attempt to launch sbt under JDK 10.

@eed3si9n eed3si9n added the ready label Feb 3, 2018
@2m
Copy link
Member Author

2m commented Feb 5, 2018

Is the validation error a result of a flaky test on windows? I was not able to find the full log of what went wrong.

@dwijnand
Copy link
Member

dwijnand commented Feb 5, 2018

The log download button is towards the top-right:

image

Anyways the error seems to be a 404 error:

[00:01:48] jdk9 v9.0.1.11 [Approved]
[00:01:48] jdk9 package files install completed. Performing other installation steps.
[00:01:49] Downloading JDK from http://download.oracle.com/otn-pub/java/jdk/9.0.1+11/jdk-9.0.1_windows-x64_bin.exe
[00:01:51] ERROR: Exception calling "DownloadFile" with "2" argument(s): "The remote server returned an error: (404) Not Found."
[00:01:52] The install of jdk9 was NOT successful.
[00:01:52] Error while running 'C:\ProgramData\chocolatey\lib\jdk9\tools\chocolateyInstall.ps1'.
[00:01:52]  See log for details.
[00:01:54] 
[00:01:54] Chocolatey installed 0/1 packages. 1 packages failed.
[00:01:54]  See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
[00:01:54] 
[00:01:54] Failures
[00:01:54]  - jdk9 (exited -1) - Error while running 'C:\ProgramData\chocolatey\lib\jdk9\tools\chocolateyInstall.ps1'.
[00:01:54]  See log for details.
[00:01:54] Command exited with code -1

@dwijnand dwijnand merged commit f035626 into sbt:master Feb 5, 2018
@dwijnand dwijnand removed the ready label Feb 5, 2018
@2m 2m deleted the wip-handle-jdk-10-version-2m branch February 5, 2018 12:11
@2m
Copy link
Member Author

2m commented Feb 5, 2018

Thanks for merging. Seems that the validation error is because of the outdated chocolatey package. The issue is being tracked here: https://chocolatey.org/packages/jdk9

@markehammons
Copy link

I'm still getting this error upon trying to launch sbt with jdk 10:

[process_args] java_version = '10'

The Java Development Kit (JDK) installation you have is not up to date.
requires at least version 1.6+, you have
version 10

Please go to http://www.oracle.com/technetwork/java/javase/downloads/ and download
a valid JDK and install before running .

I'm using the rpm repository provided by this page and I launched sbt within a directory that had an explicit sbt 1.1.1 build.properties file.

@2m
Copy link
Member Author

2m commented Mar 24, 2018

I think we need a new release of sbt-launcher as there were more fixed to the java version parsing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants