Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-organize the folder #11

Merged
merged 2 commits into from
May 13, 2022
Merged

Re-organize the folder #11

merged 2 commits into from
May 13, 2022

Conversation

supl
Copy link
Collaborator

@supl supl commented May 13, 2022

Since this repository will contain libraries for various programming languages (now we have Java and Node.js), this PR re-organize the original files into the java sub-folder.

This PR also added a README at the root.
https://github.com/scalar-labs/scalar-admin/tree/re-organize-folder

Notice: To make it simpler and singular, I remain the admin.proto file at the root and create a symbolic link to java/src/main/proto/scalar/protobuf/admin.proto.

@supl supl requested review from brfrn169 and feeblefakie May 13, 2022 02:25
@supl supl self-assigned this May 13, 2022
@supl supl changed the title Move the root folder's stuff to java/ Re-organize the folder May 13, 2022
Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 0ebd587 into main May 13, 2022
@feeblefakie feeblefakie deleted the re-organize-folder branch May 13, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants