Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Stats service #20

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Remove the Stats service #20

merged 1 commit into from
Jun 14, 2022

Conversation

supl
Copy link
Collaborator

@supl supl commented Jun 14, 2022

This PR removes the Stats service from the Scalar Admin protocol buffers.

@supl supl added the enhancement New feature or request label Jun 14, 2022
@supl supl requested review from brfrn169 and feeblefakie June 14, 2022 05:11
@supl supl self-assigned this Jun 14, 2022
@@ -108,37 +108,6 @@ com.scalar.admin.rpc.CheckPausedResponse> getCheckPausedMethod() {
return getCheckPausedMethod;
}

private static volatile io.grpc.MethodDescriptor<com.google.protobuf.Empty,
Copy link
Collaborator Author

@supl supl Jun 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is generated by the Gradle protocol buffers plugin

Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 2fe9016 into main Jun 14, 2022
@feeblefakie feeblefakie deleted the remove-stat branch June 14, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants